add python wrapper for sequence_pool #6787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The generated sequence_first_step website is : |
pkuyym
reviewed
Dec 22, 2017
| avg_x = fluid.layers.sequence_pool(input=x, pool_type='average') | ||
| sum_x = fluid.layers.sequence_pool(input=x, pool_type='sum') | ||
| sqrt_x = fluid.layers.sequence_pool(input=x, pool_type='sqrt') | ||
| max_x = fluid.layers.sequence_pool(input=x, pool_type='max') |
There was a problem hiding this comment.
Is it necessary to limit the type in (average/sum/sqrt/max)?
If so, I think it's better to add a check.
There was a problem hiding this comment.
If I limit the type in (average/sum/sqrt/max), then sequence_first_step should not be
def sequence_first_step(input, **kwargs):
return sequence_pool(input=input, pool_type="first")
It should be
def sequence_first_step(input, **kwargs):
helper = LayerHelper('sequence_pool', input=input, **kwargs)
dtype = helper.input_dtype()
pool_out = helper.create_tmp_variable(dtype)
max_index = helper.create_tmp_variable(dtype)
helper.append_op(
type="sequence_pool",
inputs={"X": input},
outputs={"Out": pool_out,
"MaxIndex": max_index},
attrs={"pooltype": "first"})
return pool_out
but max_index = helper.create_tmp_variable(dtype) could not be removed. If we want to remove it, we should add an single sequence_max_op.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6777
The generated sequence_pool website is :